Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendored copy of html5lib for Python 3.8 compatibility #6237

Closed
tirkarthi opened this issue Feb 4, 2019 · 5 comments · Fixed by #6728
Closed

Update vendored copy of html5lib for Python 3.8 compatibility #6237

tirkarthi opened this issue Feb 4, 2019 · 5 comments · Fixed by #6728
Labels
auto-locked Outdated issues that have been locked by automation project: vendored dependency Related to a vendored dependency

Comments

@tirkarthi
Copy link
Contributor

Environment

  • pip version: 19.0
  • Python version: 3.8.0
  • OS: Linux

Description

The vendored copy of html5lib is incompatible with changes to be made in CPython regarding collections import in python/cpython#10596. This is fixed on master with html5lib/html5lib-python#402 and opening this as a reminder issue as per python/cpython#10596 (comment)

cc : @pradyunsg

Thanks
@pradyunsg pradyunsg added the project: vendored dependency Related to a vendored dependency label Feb 5, 2019
@pradyunsg
Copy link
Member

We'll handle this once the release is made by html5lib. :)

@uranusjr uranusjr mentioned this issue Apr 18, 2019
Closed
@gaborbernat
Copy link

Blocked by html5lib/html5lib-python#419

@zooba
Copy link
Contributor

zooba commented Jun 27, 2019

Since we know their next release (whenever it happens) will include this fix, can we just patch it in pip? I'm keen to upgrade the bundled version of pip for Python 3.8, but we really ought to do that sooner rather than later.

@pradyunsg
Copy link
Member

Yep yep. Happy to hold a patch for this.

@yan12125 yan12125 mentioned this issue Jul 18, 2019
Merged
@yan12125
Copy link
Contributor

Yep yep. Happy to hold a patch for this.

Glad to hear that one of major pip developers is fine with a patch. I created #6728 to fix the issue.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation project: vendored dependency Related to a vendored dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an html5lib patch for Python 3.9 compatibility
5 participants
@gaborbernat @zooba @yan12125 @pradyunsg @tirkarthi