-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New style {format} strings in logging calls #7009
Comments
Relabeled, since I think everyone would agree that switching to a single format would be best. :) |
The logging module can handle brace formatting, but IIRC the conversion needs to be done in one shot, not incrementally. |
Hi there, this seems to have been done in GH-7826, then reverted because of regression (probably due to some minor mistake have to do with implicit use of kwargs, e.g. |
Looking at the Python 2 support situation for this change, I think we should wait until Python 2 support is dropped to do this. |
Oops I saw the comment in the PR and reply to it first. There are 2 things needed to be changed:
|
Closing this out. I don’t think we’d be able to do this in the near future. If someone thinks it’s possible, let’s open a new issue instead. |
I do wonder if there's some way to make the format strings for logging calls to use the new-style formatting.
Originally posted by @pradyunsg in #6973 (comment)
It'd be nice to be able to switch over TBH.
The text was updated successfully, but these errors were encountered: