Deprecate git+git@ form of VCS requirements #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
deprecate-gitgitarobase-sbi
branch
from
8407078
to
cb4de30
Compare
xavfernandez
approved these changes
Jan 2, 2020
sbidoul
changed the title
sbidoul
added
type: deprecation
uranusjr
reviewed
Jan 2, 2020
sbidoul
force-pushed
the
deprecate-gitgitarobase-sbi
branch
2 times, most recently
from
806bfa2
to
b84c4f1
Compare
atugushev
reviewed
Jan 2, 2020
sbidoul
force-pushed
the
deprecate-gitgitarobase-sbi
branch
from
b84c4f1
to
cf071de
Compare
chrahunt
suggested changes
Jan 3, 2020
in the deprecation message
chrahunt
approved these changes
Jan 8, 2020
|
It looks like all feedback has been resolved, so I will merge this. Thank you @sbidoul |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6293, #2038
The
git+git@form of VCS pseudo-URL seems to be supported for editable installs only. Everywhere else, proper URLs are required.This might be accidental and due to a less strict VCS URL detection mechanism for editable installs.
Since this creates bugs (in pip freeze) and confusion, let's progressively require proper URLs for editable installs too.
I propose a 1 year deprecation period.