Git revisions ignored

[vbabiy]

pip currently ignores git commit revisions (unless they are the full SHA1 of a branch or tag) which results in pip installing whatever git clone pulls down instead of checking out the specified revision.

I may have bungled my pull request, but I've fixed this issue in my fork => http://bitbucket.org/jsma/pip/changeset/9a7c74d5f403

---

• Bitbucket: https://bitbucket.org/ianb/pip/issue/138
• Originally Reported By: John-Scott Atlakson
• Originally Created At: 2010-07-02 16:51:57

[vbabiy]

In case pull requests are ignored, here are my notes from my request (patch
attached):

I've fixed an issue with the git backend. It was ignoring commit SHA1's and
always installing the tip of a package.

The main bug was that it would only do a checkout if rev_options != checked_rev
(http://bitbucket.org/ianb/pip/src/31ab9bbc9c7f/pip/vcs/git.py#cl-124).

The check_rev_options() method would always return the rev argument
unmodified if it wasn't the full SHA1 of a tag or branch. Partial SHA1's of
tags or branches would fail the if rev in revisions test, also returning
rev unmodified
(http://bitbucket.org/ianb/pip/src/31ab9bbc9c7f/pip/vcs/git.py#cl-87).
This meant it would never pass the inequality test.

---

Original Comment By: John-Scott Atlakson

[vbabiy]

Hi jsma, Your patch has been applied to my py2x fork. I hope it will be merged
soon. I added some other tests and saw you solved two issues :)

Thanks!

---

Original Comment By: Hugo Lopes Tavares

[vbabiy]

Issue #155 was marked as a duplicate of this issue.

-revision-is

---

Original Comment By: Hugo Lopes Tavares

[vbabiy]

• Changed status from open to resolved.

---

Original Comment By: Hugo Lopes Tavares