Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Ask for confirmation if "pip install pyproject.toml" or similar indicates wrong unsage #9943

Open
MartinThoma opened this issue May 4, 2021 · 0 comments

Comments

@MartinThoma
Copy link

MartinThoma commented May 4, 2021

What's the problem this feature will solve?
People sometimes execute commands like the following and are surprised of the behavior:

  • pip install pyproject.toml
  • pip install requirements.txt

This also has the potential to install malware as pyproject.toml and requirements-dev.txt. The requirements.txt cannot be registered and triggers "The name 'requirements.txt' isn't allowed. See https://pypi.org/help/#project-name for more information."

Describe the solution you'd like

  1. User enters "pip install foobar"
  2. pip checks if "foobar" is a file in the current directory
  3. If it is, ask for confirmation if the project from pypi (given the link) should be installed or if the local file should be used (abort)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant