Skip to content

Commit

Permalink
Fix file handle leaks
Browse files Browse the repository at this point in the history
- Fix #3020
- Fix #3088
- Patch delegator
- Add weakref finalizer for tempfiles

Signed-off-by: Dan Ryan <dan@danryan.co>
  • Loading branch information
techalchemy committed Oct 24, 2018
1 parent c072294 commit 940f390
Show file tree
Hide file tree
Showing 14 changed files with 619 additions and 393 deletions.
1 change: 1 addition & 0 deletions news/3020.feature.rst
@@ -0,0 +1 @@
Updated ``crayons`` patch to enable colors on native powershell but swap native blue for magenta.
1 change: 1 addition & 0 deletions news/3088.bugfix.rst
@@ -0,0 +1 @@
Fixed a bug which caused ``Unexpected EOF`` errors to be thrown when PIP awaited input from users who put login credentials in their environment.
1 change: 1 addition & 0 deletions news/3089.feature.rst
@@ -0,0 +1 @@
Added windows-compatible spinner via upgraded ``vistir`` dependency.
11 changes: 11 additions & 0 deletions news/3089.vendor.rst
@@ -0,0 +1,11 @@
Updated vendored dependencies:
- ``certifi 2018.08.24 => 2018.10.15``
- ``urllib3 1.23 => 1.24``
- ``requests 2.19.1 => 2.20.0``
- ``shellingham ``1.2.6 => 1.2.7``
- ``tomlkit 0.4.4. => 0.4.6``
- ``vistir 0.1.6 => 0.1.8``
- ``pythonfinder 0.1.2 => 0.1.3``
- ``requirementslib 1.1.9 => 1.1.10``
- ``backports.functools_lru_cache 1.5.0 (new)``
- ``cursor 1.2.0 (new)``
6 changes: 3 additions & 3 deletions pipenv/_compat.py
Expand Up @@ -59,10 +59,10 @@ def detach(self):
return False


if six.PY2:
from vistir.compat import ResourceWarning

class ResourceWarning(Warning):
pass

warnings.filterwarnings("ignore", category=ResourceWarning)


def pip_import(module_path, subimport=None, old_path=None):
Expand Down

0 comments on commit 940f390

Please sign in to comment.