Dial back Pythonfinder integration effort #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
pythonfinder-lite
branch
2 times, most recently
from
4d54c61
to
893fb8f
Compare
techalchemy
force-pushed
the
pythonfinder-lite
branch
9 times, most recently
from
9c68041
to
ff985cc
Compare
techalchemy
reviewed
Jul 17, 2018
pipenv/core.py
Outdated
| '{} -c "import sys; print(sys.executable)"'.format(line), | ||
| ) | ||
| if not isinstance(output, str): | ||
| output = output.decode(sys.getdefaultencoding()) |
There was a problem hiding this comment.
fs_str(output)
But we don't need to handle this anyway
techalchemy
reviewed
Jul 17, 2018
pipenv/core.py
Outdated
| c = delegator.run( | ||
| cmd, block=False, timeout=PIPENV_TIMEOUT, env=pip_config, | ||
| ) | ||
| c.block() |
There was a problem hiding this comment.
If we don't block here and we pass block=False we can't read the output...
There was a problem hiding this comment.
I think it should be indented inside the with block?
There was a problem hiding this comment.
makes sense to me, I just put it there because of no reason in particular
techalchemy
force-pushed
the
pythonfinder-lite
branch
from
8143f40
to
de8ddb0
Compare
|
just rebased this, I think I'm probably good with it if you are (I can cut 1.0 of pythonfinder if we are satisfied) |
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
This is still not working though.
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
pythonfinder-lite
branch
from
9b8b999
to
ef060c4
Compare
Signed-off-by: Dan Ryan <dan@danryan.co>
uranusjr
added
the
PR: awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let’s try this a little at a time…
This only uses Pythonfinder in
find_a_system_python, and leaves everything else alone. I hope this approach will make rewrites easier to tackle.