Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial back Pythonfinder integration effort #2582

Merged
merged 57 commits into from Jul 30, 2018
Merged

Dial back Pythonfinder integration effort #2582

merged 57 commits into from Jul 30, 2018

Conversation

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 14, 2018

Let’s try this a little at a time…

This only uses Pythonfinder in find_a_system_python, and leaves everything else alone. I hope this approach will make rewrites easier to tackle.

@uranusjr uranusjr force-pushed the pythonfinder-lite branch 2 times, most recently from 4d54c61 to 893fb8f Jul 14, 2018
@techalchemy techalchemy force-pushed the pythonfinder-lite branch 9 times, most recently from 9c68041 to ff985cc Jul 15, 2018
'{} -c "import sys; print(sys.executable)"'.format(line),
)
if not isinstance(output, str):
output = output.decode(sys.getdefaultencoding())

This comment has been minimized.

@techalchemy

techalchemy Jul 17, 2018
Member

fs_str(output)

But we don't need to handle this anyway

c = delegator.run(
cmd, block=False, timeout=PIPENV_TIMEOUT, env=pip_config,
)
c.block()

This comment has been minimized.

@techalchemy

techalchemy Jul 17, 2018
Member

If we don't block here and we pass block=False we can't read the output...

This comment has been minimized.

@uranusjr

uranusjr Jul 17, 2018
Author Member

I think it should be indented inside the with block?

This comment has been minimized.

@techalchemy

techalchemy Jul 17, 2018
Member

makes sense to me, I just put it there because of no reason in particular

@uranusjr uranusjr added this to In progress in 2018.7.x Release via automation Jul 18, 2018
@techalchemy techalchemy force-pushed the pythonfinder-lite branch from 8143f40 to de8ddb0 Jul 18, 2018
@techalchemy
Copy link
Member

@techalchemy techalchemy commented Jul 18, 2018

just rebased this, I think I'm probably good with it if you are (I can cut 1.0 of pythonfinder if we are satisfied)

techalchemy and others added 21 commits Jul 17, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
This is still not working though.
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy force-pushed the pythonfinder-lite branch from 9b8b999 to ef060c4 Jul 25, 2018
techalchemy and others added 2 commits Jul 25, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
@uranusjr uranusjr merged commit a853814 into master Jul 30, 2018
2 checks passed
2 checks passed
@erinxocon
VSTS: pipenv-Python Package-CI 20180730.3 succeeded
Details
buildkite/pipenv Build #1050 passed (11 minutes, 5 seconds)
Details
2018.7.x Release automation moved this from In progress to Done Jul 30, 2018
@uranusjr uranusjr deleted the pythonfinder-lite branch Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants