Create virtualenvs directory if it does not exist #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
added a commit
to Enzime/pipenv
that referenced
this pull request
Sep 21, 2018
uranusjr
requested changes
Sep 21, 2018
Enzime
force-pushed
the
fix/no-virtualenv-dir
branch
from
a06056a
to
55be407
Compare
|
@uranusjr have you had a chance to check my PR again? |
uranusjr
approved these changes
Sep 29, 2018
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This PR fixes #2786 as
pipenvtries to iterate throughWORKON_HOME(virtualenvsfolder) without ensuring it exists first.The fix
Creating the
WORKON_HOMEdirectory from insidepipenv/utils.py:get_workon_home.The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.