Installing from git and specifying the platform or os raises an InvalidMarker error #3249
Comments
Hey @samfrench, We did a quick check and this issue looks very darn similar to This could be a coincidence, but if any of these issues solves your problem then I did a good job If not, the maintainers will get to this issue shortly. Cheers, |
Ah, technically VCS repos don't really have this capability when they aren't editable I guess. I can just turn the validation aspect of this off to fix it I believe |
techalchemy
added a commit
that referenced
this issue
Nov 19, 2018
- Parsing of markers in non-editable vcs requirements was broken - This PR adds some VCS repos, some utility pipfile generation functions and some fixture helpers - Fixes #3249 Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy, it seems the issue I raised is currently the expected behaviour. You make it sound simple to fix. If git repos could allow markers to install or skip specific os or platforms, this would be ideal. Thank you for taking a look at this. I'll keep an eye on when the corresponding pr is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
When running
pipenv install
using Python3 and pipenv version 2018.11.14, if I specify a platform for a package from GitHub I get an InvalidMarker error.The platform specifications work fine on other modules when not using a git repo.
Expected result
The packages to be able to be installed or ignored from GitHub depending if the platform matched. The same installation behaviour as the packages that are not from GitHub.
Steps to replicate
Pipfile with the platform matchers.
Using this without "markers" produced the same issue.
I am on a Mac and using python 3.7.
The text was updated successfully, but these errors were encountered: