Remove old way of generting requirements. #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
approved these changes
Aug 6, 2022
|
|
|
Can you please open a separate issue for that? |
felixedel
added a commit
to bmwcarit/zubbi
that referenced
this pull request
Oct 10, 2022
This has changed in the meantime, see pypa/pipenv#5200.
cakekoa
added a commit
to guardicore/monkey
that referenced
this pull request
Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
cakekoa
added a commit
to guardicore/monkey
that referenced
this pull request
Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
cakekoa
added a commit
to guardicore/monkey
that referenced
this pull request
Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Feb 27, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Feb 28, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
mssalvatore
pushed a commit
to guardicore/monkey
that referenced
this pull request
Mar 1, 2023
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 8, 2023
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
thatgeeman
added a commit
to thatgeeman/workflows
that referenced
this pull request
Aug 19, 2023
pipenv==2022.8.5 # because of `lock -r` change in pypa/pipenv#5200
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…ot#7764) In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in dependabot#7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
stefanfreitag
added a commit
to stefanfreitag/aws-cdk
that referenced
this pull request
Dec 10, 2023
As part of the pipenv release 2022.8.13 the deprecated way of generating requirements "pipenv install -r" or "pipenv lock -r" has been removed in favor of the "pipenv requirements" command. * [Reference to pipenv CHANGELOG](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md#2022813-2022-08-13) * [Refernce to relevant pipenv pull request](pypa/pipenv#5200) Fixes aws#28015 by implementing the proposed change.
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Dec 18, 2023
As part of the pipenv release 2022.8.13 the deprecated way of generating requirements ("pipenv install -r" or "pipenv lock -r") has been removed in favor of the "pipenv requirements" command.
See #28015 for the motivation behind this change.
* [Reference to pipenv CHANGELOG](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md#2022813-2022-08-13)
* [Refernce to relevant pipenv pull request](pypa/pipenv#5200)
Closes #28015 .
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
Remove the deprecated
install -rcommand and simplify the CLI interface + logic.Fixes: #5198
The fix
We have the
pipenv requirementscommand now.The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.