Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--keep-outdated deprecation text is missing spaces #5618

Closed
kurtmckee opened this issue Feb 20, 2023 · 2 comments · Fixed by #5619
Closed

--keep-outdated deprecation text is missing spaces #5618

kurtmckee opened this issue Feb 20, 2023 · 2 comments · Fixed by #5619

Comments

@kurtmckee
Copy link
Contributor

Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Pipenv.

Check the diagnose documentation for common issues before posting! We may close your issue if it is very similar to one of them. Please be considerate, or be on your way.

Make sure to mention your debugging experience if the documented solution failed.

Issue description

The text displayed when using the --keep-outdated flag is missing a space.

This was observed while reviewing a failed workflow in the actions/setup-python repo:

The flag --keep-outdated has been deprecated for removal.The flag [...]
                                                 ^^^^^^^^^^^

This occurs due to missing spaces in pipenv/cli/options.py:

click.secho(
"The flag --keep-outdated has been deprecated for removal."
"The flag does not respect package resolver results and leads to inconsistent lock files. "

I'll submit a patch shortly.

@matteius
Copy link
Member

kurtmckee added a commit to kurtmckee/pr-pipenv that referenced this issue Feb 20, 2023
kurtmckee added a commit to kurtmckee/pr-pipenv that referenced this issue Feb 20, 2023
@kurtmckee
Copy link
Contributor Author

Thanks for the fast response, @matteius!

This is happening just a few lines above the changes made in that PR. Lines 160 and 161 were not affected by that PR.

https://github.com/pypa/pipenv/pull/5617/files#diff-f303741aa3a324b79c0fca4837cc712dc7379fd76479ceb3b71caacc92a8f562R160-R161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants