Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipenv install to successfully use pip9 #2016

Closed
wants to merge 1 commit into from

Conversation

techalchemy
Copy link
Member

Signed-off-by: Dan Ryan dan@danryan.co

@techalchemy techalchemy added this to the 11.10.1 milestone Apr 17, 2018
@uranusjr
Copy link
Member

Wait, I don’t think this would work if system is false? which('python', allow_global=system) would return the virtualenv Python, which would not be able to locate pipenv.vendor.pip9.

@techalchemy
Copy link
Member Author

@uranusjr doesn’t matter, it runs with a temporary environment that adds the vendor directory to the python path.

@techalchemy
Copy link
Member Author

Tracking pypa/pip#5251 in case pip 10.0.1 is something we can delay this release for and revert this hackery

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy deleted the fix-pipenv-install branch September 5, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants