New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VCS locking and updating #2209

Merged
merged 5 commits into from May 23, 2018

Conversation

Projects
2 participants
@techalchemy
Member

techalchemy commented May 16, 2018

Lock vcs deps to exact commit with dependencies

  • Manually obtain and update VCS repository with exact commit
  • Always store exact commit in the lockfile
  • Fixes #2180, #1690, #1611, #2096

techalchemy added some commits May 15, 2018

Lock vcs refs properly
- Still need to actually run setup.py

Signed-off-by: Dan Ryan <dan@danryan.co>
Lock vcs deps to exact commit with dependencies
 - Manually obtain and update VCS repository with exact commit
 - Always store exact commit in the lockfile
 - Fixes #2180, #1690, #1611, #2096

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy and others added some commits May 23, 2018

@kennethreitz

This comment has been minimized.

Contributor

kennethreitz commented May 23, 2018

why is this not merged?

@kennethreitz kennethreitz merged commit e74db18 into master May 23, 2018

0 of 2 checks passed

buildkite/pipenv Build #172 started
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@kennethreitz kennethreitz deleted the bugfix/vcs-updates branch May 23, 2018

@techalchemy techalchemy moved this from Done to Needs Changelog in 2018.06.x Release Jun 16, 2018

@techalchemy techalchemy moved this from Needs Changelog to Done in 2018.06.x Release Jun 17, 2018

@techalchemy techalchemy moved this from Done to Needs tests in 2018.06.x Release Jun 23, 2018

@techalchemy techalchemy moved this from Needs tests to Done in 2018.06.x Release Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment