New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont create virtualenvs with `--system --deploy` #2301

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
2 participants
@techalchemy
Member

techalchemy commented Jun 4, 2018

Signed-off-by: Dan Ryan dan@danryan.co

Dont create virtualenvs with `--system --deploy`
- Fixes #2219, #2273

Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy merged commit e937d85 into master Jun 4, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
buildkite/pipenv Build #237 passed (8 minutes, 1 second)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
@AlJohri

This comment has been minimized.

Contributor

AlJohri commented Jun 4, 2018

@techalchemy nice!

@techalchemy techalchemy deleted the bugfix/2219-system-creates-virtualenv branch Jun 8, 2018

@techalchemy techalchemy moved this from Done to Needs Changelog in 2018.06.x Release Jun 16, 2018

@techalchemy techalchemy moved this from Needs Changelog to Done in 2018.06.x Release Jun 16, 2018

@techalchemy techalchemy moved this from Done to Needs tests in 2018.06.x Release Jun 23, 2018

techalchemy added a commit that referenced this pull request Jun 24, 2018

Tests for #2273 and #2301
Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy moved this from Needs tests to Done in 2018.06.x Release Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment