Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipenv crashes #2388

Closed
wants to merge 5 commits into from
Closed

Fix pipenv crashes #2388

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5ea0ed
Fix cli option usage error
maxkrivich Jun 20, 2018
40612f2
Fix empty indexes in cli param
maxkrivich Jun 20, 2018
d72f668
Change exception message
maxkrivich Jun 20, 2018
597fabd
Update too complex if statement
maxkrivich Jun 20, 2018
7516ead
Fix CI errors
maxkrivich Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions pipenv/core.py
View file
Open in desktop
Expand Up @@ -1889,12 +1889,16 @@ def do_install(
# Capture -e argument and assign it to following package_name.
more_packages = list(more_packages)
if package_name == '-e':
if not more_packages:
raise click.BadArgumentUsage('Please provide path to setup.py')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message could be misleading. We don’t want a path to setup.py, but to the directory containing it. I would use something like “path to editable package (e.g. the directory containing setup.py)” instead.

package_name = ' '.join([package_name, more_packages.pop(0)])
# capture indexes and extra indexes
line = [package_name] + more_packages
index_indicators = ['-i', '--index', '--extra-index-url']
index, extra_indexes = None, None
if more_packages and any(more_packages[0].startswith(s) for s in index_indicators):
if len(more_packages) < 2:
raise click.BadArgumentUsage('Please provide index value')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the logic in this block can be rewritten a bit to make the checks clearer. Right now the various checks are a bit convoluted, and require a lot of context to be understood. Why does it use more_packages here, but package_names below? How do they relate to line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr I agree with you about some extra context what you should keep in mind. I'll try to rewrite this block.

line, index = split_argument(' '.join(line), short='i', long_='index', num=1)
line, extra_indexes = split_argument(line, long_='extra-index-url')
package_names = line.split()
Expand Down