Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _get_virtualenv_hash function #2883

Merged
merged 2 commits into from Nov 3, 2018
Merged

Fix _get_virtualenv_hash function #2883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545a236
Fix _get_virtualenv_hash function
Jamim Nov 2, 2018
780e879
Merge branch 'master' into fix/get-virtualenv-hash
techalchemy Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -8,6 +8,9 @@
.AppleDouble
.LSOverride

# PyCharm
.idea/

# VSCode
.vscode

Expand Down
1 change: 1 addition & 0 deletions news/3151.bugfix
View file
Open in desktop
@@ -0,0 +1 @@
Fix project path hashing logic in purpose to prevent collisions of virtual environments.
2 changes: 1 addition & 1 deletion pipenv/project.py
View file
Open in desktop
Expand Up @@ -449,7 +449,7 @@ def get_name(name, location):
# In-project venv
# "Proper" path casing (on non-case-sensitive filesystems).
if (
fnmatch.fnmatch("A", "a")
not fnmatch.fnmatch("A", "a")
or self.is_venv_in_project()
or get_workon_home().joinpath(venv_name).exists()
):
Expand Down