Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add spinner during locking #2993

Closed
wants to merge 6 commits into from
Closed

WIP: Add spinner during locking #2993

wants to merge 6 commits into from

Conversation

@techalchemy
Copy link
Member

@techalchemy techalchemy commented Oct 10, 2018

Signed-off-by: Dan Ryan dan@danryan.co

techalchemy added 3 commits Oct 10, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Additional fix for #2981

Signed-off-by: Dan Ryan <dan@danryan.co>
@@ -1344,7 +1345,8 @@ def pip_install(
index_source = index_source.copy()
except SourceNotFound:
src_name = project.src_name_from_url(index)
verify_ssl = True if index not in trusted_hosts else False
index_url = parse_url(index)
verify_ssl = True if index_url.host not in trusted_hosts else False

This comment has been minimized.

@Jamim

Jamim Oct 11, 2018
Contributor

I believe that the following form is enough:

verify_ssl = index_url.host not in trusted_hosts

This comment has been minimized.

@techalchemy

techalchemy Oct 11, 2018
Author Member

Indeed it is! thanks for the feedback :)

This comment has been minimized.

@techalchemy

techalchemy Oct 11, 2018
Author Member

bigger fish to fry on this one -- VCS installs are throwing permissions errors :(

@@ -1355,7 +1357,8 @@ def pip_install(
extra_src = project.find_source(idx)
except SourceNotFound:
src_name = project.src_name_from_url(idx)
verify_ssl = True if idx not in trusted_hosts else False
src_url = parse_url(idx)
verify_ssl = True if src_url.host not in trusted_hosts else False

This comment has been minimized.

@Jamim

Jamim Oct 11, 2018
Contributor

verify_ssl = src_url.host not in trusted_hosts
techalchemy added 3 commits Oct 11, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
…nes on windows

Signed-off-by: Dan Ryan <dan@danryan.co>
- Update vendored deps
- Fix minor bugs

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy changed the title Add spinner during locking WIP: Add spinner during locking Oct 11, 2018
@techalchemy
Copy link
Member Author

@techalchemy techalchemy commented Oct 16, 2018

Closing, I have a better implementation of this

@frostming frostming deleted the add-locking-spinner branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants