New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor #3096

Merged
merged 13 commits into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@techalchemy
Member

techalchemy commented Oct 24, 2018

  • Fix file handle leaks
    • Patch delegator
    • Add weakref finalizer for tempfiles
    • Fix extraneous resource warnings
    • Fix filesystem output stream encoding issues
  • Fix editable dependency installation when markers are present
  • Fix pythonfinder non-standard python name issues
  • Cleanup some unused code
  • Provide full convenience layer to Pipfile and Pipfile.lock in requirementslib
  • Upgrade pythonfinder
  • Upgrade requirementslib
  • Vendor backported version of functools.lru_cache for performance
  • Update shellingham, tomlkit, requests, urllib3, certifi, vistir and parse.py
  • Fixes #3020
  • Fixes #3088
  • Fixes #2820
  • Fixes #2852
  • Fixes #2320
  • Fixes #3017
  • Fixes #3014
  • Fixes #3021
  • Fixes #3019
  • Fixes #3090
  • Fixes #3094
  • Fixes #3109
  • Fixes #3117
  • Fixes #3114
  • Fixes #3102
  • Fixes #3095
  • Fixes #2460

techalchemy added some commits Oct 22, 2018

Update requirementslib, requests and vistir
Signed-off-by: Dan Ryan <dan@danryan.co>
Fix delegator leaky file handles
Signed-off-by: Dan Ryan <dan@danryan.co>
Set environment before calling which
Signed-off-by: Dan Ryan <dan@danryan.co>
Fix error handling with fallback in `which` implementation
Signed-off-by: Dan Ryan <dan@danryan.co>
Fix virtualenv creation and error logging
Signed-off-by: Dan Ryan <dan@danryan.co>
Upgrade vendored dependencies
- Upgrade pythonfinder
- Upgrade vistir
- Upgrade requirementslib
- Vendor backported version of `functools.lru_cache` for performance
- Fix editable dependency installation when markers are present
- Fix extraneous resource warnings
- Fix filesystem output stream encoding issues
- Fix pythonfinder non-standard python name issues
- Provide full interaction layer to `Pipfile` and `Pipfile.lock` in
  requirementslib
- Fixes #3017
- Fixes #3014
- Fixes #3021
- Fixes #3019

Signed-off-by: Dan Ryan <dan@danryan.co>

Update vendored dependencies

- Update shellingham, tomlkit, requests, urllib3, certifi, vistir and
  parse
- Fixes #2820
- Fixes #2852

Signed-off-by: Dan Ryan <dan@danryan.co>

Cleanup old vendored dependencies

Signed-off-by: Dan Ryan <dan@danryan.co>
Vendor boltons
Signed-off-by: Dan Ryan <dan@danryan.co>

Update vendored dependencies

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix file handle leaks

- Fix #3020
- Fix #3088
- Patch delegator
- Add weakref finalizer for tempfiles

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix spinner handlers on windows

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix spinner output and encoding issue

Signed-off-by: Dan Ryan <dan@danryan.co>

fix encoding

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix unicode output on windows, fix tomlkit imports

Signed-off-by: Dan Ryan <dan@danryan.co>

Unvendor boltons, fix compatibility, update merge functionalities

Signed-off-by: Dan Ryan <dan@danryan.co>

Update pythonfinder, vistir version, requirementslib version

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix vendoring script

Signed-off-by: Dan Ryan <dan@danryan.co>

Silence pip version checks

Signed-off-by: Dan Ryan <dan@danryan.co>

Add debugging to locking

Signed-off-by: Dan Ryan <dan@danryan.co>
Update pythonfinder
Signed-off-by: Dan Ryan <dan@danryan.co>

More debugging info

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix stdout write bugs

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix spinner invocations

Signed-off-by: Dan Ryan <dan@danryan.co>

Create missing directory

Signed-off-by: Dan Ryan <dan@danryan.co>

Filesystem encode envvars

Signed-off-by: Dan Ryan <dan@danryan.co>

convert envvars to strings

Signed-off-by: Dan Ryan <dan@danryan.co>

Update encodings

Signed-off-by: Dan Ryan <dan@danryan.co>

Update vistir to init colorama

Signed-off-by: Dan Ryan <dan@danryan.co>

Update vistir version number

Signed-off-by: Dan Ryan <dan@danryan.co>

add some debugging and vsts changes

Signed-off-by: Dan Ryan <dan@danryan.co>

fix delegator mod

Signed-off-by: Dan Ryan <dan@danryan.co>

Log to stderr so we can see it

Signed-off-by: Dan Ryan <dan@danryan.co>

Log to stderr so we can see it

Signed-off-by: Dan Ryan <dan@danryan.co>

Try importing colorama...

Signed-off-by: Dan Ryan <dan@danryan.co>

change variable setting syntax

Signed-off-by: Dan Ryan <dan@danryan.co>
Fix syntax issues in vsts
Signed-off-by: Dan Ryan <dan@danryan.co>

Fix syntax issues in vsts

Signed-off-by: Dan Ryan <dan@danryan.co>
Finish updating vendored deps
Signed-off-by: Dan Ryan <dan@danryan.co>

Update delegator patch

Signed-off-by: Dan Ryan <dan@danryan.co>

Update patches for pip

Signed-off-by: Dan Ryan <dan@danryan.co>

Update vendored deps

Signed-off-by: Dan Ryan <dan@danryan.co>

Update patches

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix imports to use pip shims instead of direct imports

Signed-off-by: Dan Ryan <dan@danryan.co>

Update vendoring scripts and pip shims

Signed-off-by: Dan Ryan <dan@danryan.co>

Log to stdout in real time during verbose logging

Signed-off-by: Dan Ryan <dan@danryan.co>

Don’t log environment

Fix unicode decoding issues

Signed-off-by: Dan Ryan <dan@danryan.co>

Only set buffers on ttys

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix typo

Signed-off-by: Dan Ryan <dan@danryan.co>

Use default encodings

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix encodings and run only failing tests

Signed-off-by: Dan Ryan <dan@danryan.co>
Update project and spinner outputs
Signed-off-by: Dan Ryan <dan@danryan.co>

Try again

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix test config to skip failed removals

Signed-off-by: Dan Ryan <dan@danryan.co>

Update piptools to handle some errors

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix test config to skip failed removals

Signed-off-by: Dan Ryan <dan@danryan.co>

Update tempfile.py

Use vistirs temporary directory implementation

Update temp_dir.py

Force pip to use weakrefs in tempdirs

Fix pip implementation to set name of tempdir

typo fix

Signed-off-by: Dan Ryan <dan@danryan.co>

fix pip tempdir implementation

Signed-off-by: Dan Ryan <dan@danryan.co>

Update tempfiles to use weakrefs

Signed-off-by: Dan Ryan <dan@danryan.co>

fix patch paths

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix pip tempdir implementation

Signed-off-by: Dan Ryan <dan@danryan.co>

Syntax error fix

Signed-off-by: Dan Ryan <dan@danryan.co>

Unconstrain windows tests

Signed-off-by: Dan Ryan <dan@danryan.co>

Update dependencies, add news

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix pythonfinder path search nesting bug

- Fixes #3121

Signed-off-by: Dan Ryan <dan@danryan.co>

Update requirementslib

- Fix subdirectory issue

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix logic error

Signed-off-by: Dan Ryan <dan@danryan.co>

conditional builds

Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy force-pushed the update-vendor branch from c0fdd8a to d069dff Oct 30, 2018

techalchemy added some commits Oct 30, 2018

Fix requirementslib update
Signed-off-by: Dan Ryan <dan@danryan.co>
Exclude setup_path from pipfile
Signed-off-by: Dan Ryan <dan@danryan.co>

@techalchemy techalchemy merged commit 205fd25 into master Oct 30, 2018

2 checks passed

pipenv CI (Linux) #Pipenv Build Rules succeeded
Details
pipenv CI (Windows) #Pipenv Build Rules succeeded
Details

@techalchemy techalchemy deleted the update-vendor branch Oct 30, 2018

@mgeisler

This comment has been minimized.

mgeisler commented Nov 7, 2018

The update of shellingham to version 1.2.7 fixes sarugaku/shellingham#15, which is a bug that's hitting us a lot in CI. We've now ported the patch into our internal Nix packaging of Pipenv.

I think the bug is important enough to make a new Pipenv release sooner rather than later :-)

@eolo999

This comment has been minimized.

eolo999 commented Nov 13, 2018

I am the creator of issue #3090 and I am curious to know if you have some ideas about the possible release date.

@techalchemy

This comment has been minimized.

Member

techalchemy commented Nov 13, 2018

Today. Windows test just passed.

@eolo999

This comment has been minimized.

eolo999 commented Nov 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment