handle [[source]] without url - raise PipenvUsageError #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGold
changed the title
jxltom
reviewed
Jan 17, 2019
|
Thanks for the PR! Do you mind merging |
jxltom
reviewed
Jan 17, 2019
jxltom
reviewed
Jan 17, 2019
AdamGold
force-pushed
the
feature/pip_source_args_error_handling
branch
from
e47a813
to
070da4b
Compare
AdamGold
force-pushed
the
feature/pip_source_args_error_handling
branch
from
070da4b
to
d6b20a7
Compare
|
All done 🎉 |
…re descriptive. (+1 squashed commit) Squashed commits: [b00fb5b] fixed test getting empty URL in source
AdamGold
force-pushed
the
feature/pip_source_args_error_handling
branch
from
d6b20a7
to
c3e3cfb
Compare
|
Thanks @AdamGold ! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
Fixes #2373 where
sources[0]['url']raises a KeyError.The fix
Raises PipenvUsageError with better description.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.