Print -e option and path for editable package when using pipenv requirements
#5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyaaaa
changed the title
-e option and path for editable package-e option and path for editable package when using pipenv requirements
matteius
reviewed
Apr 22, 2022
oz123
requested changes
Apr 22, 2022
|
@hoyaaaa It still needs a bugfix news fragment and then we can approve/run and I think it will be good to go. |
oz123
approved these changes
Apr 22, 2022
oz123
approved these changes
Apr 22, 2022
oz123
approved these changes
Apr 22, 2022
matteius
approved these changes
Apr 22, 2022
hoyaaaa
force-pushed
the
fix/export-requirments-editable-package
branch
from
544f7d0
to
b9c5061
Compare
fraser-langton
pushed a commit
to fraser-langton/pipenv
that referenced
this pull request
Apr 25, 2022
…quirements` (pypa#5071) * Print `-e` option and path for editable package * Reduce depth for logical complexity * Add news fragment
2 tasks
oz123
added a commit
that referenced
this pull request
Apr 25, 2022
Solved by using existing convert_deps_to_pip function. Fix #5076. Original implementation by @fraser-langton. This also solves the export of packages with editable mode, as suggested by @hoyaaaa (#5071).
oz123
added a commit
that referenced
this pull request
Apr 25, 2022
Solved by using existing convert_deps_to_pip function. Fix #5076. Original implementation by @fraser-langton. This also solves the export of packages with editable mode, as suggested by @hoyaaaa (#5071).
oz123
added a commit
that referenced
this pull request
Apr 26, 2022
Solved by using existing convert_deps_to_pip function. Fix #5076. Original implementation by @fraser-langton. This also solves the export of packages with editable mode, as suggested by @hoyaaaa (#5071).
oz123
added a commit
that referenced
this pull request
Apr 26, 2022
Solved by using existing convert_deps_to_pip function. Fix #5076. Original implementation by @fraser-langton. This also solves the export of packages with editable mode, as suggested by @hoyaaaa (#5071).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Fix #5070
The fix
If the package is editable, print
-eoption and path when usingpipenv requirementsThe checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.