Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when auto completing install and uninstall #5225

Merged
merged 3 commits into from Aug 6, 2022
Merged

Conversation

bakhtiary
Copy link
Contributor

The issue

#5214

This commit fixes the auto completing crash mentioned in the above command.

The fix

The bug is related to click and I have opened a corresponding issue in their github:
pallets/click#2336

The main problem is that expose_value=False when used for arguments breaks the autocomplete.
The best solution is to fix click and then vendor the new version. However "expose_value=False" doesn't do anything for us as far as I can see. So removing it or setting it to true is a viable option.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius
Copy link
Member

matteius commented Aug 6, 2022

@bakhtiary The linter step failed on the pre-commit check for the news fragment -- could you run this and commit the changes?
pre-commit run --all-files --verbose --show-diff-on-failure

@bakhtiary
Copy link
Contributor Author

bakhtiary commented Aug 6, 2022 via email

@oz123 oz123 merged commit b08dabd into pypa:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants