Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Named Package Categories #5366

Merged
merged 49 commits into from
Oct 8, 2022
Merged

Support Named Package Categories #5366

merged 49 commits into from
Oct 8, 2022

Conversation

matteius
Copy link
Member

Thank you for contributing to Pipenv!

The issue

Fixes #4745

Description

Named package categories have many potential use cases -- including installing pre-requisite installation packages, system specific platform lock sections, using a single Pipfile for many sub-projects, and so much more!

This is a full feature PR to support --categories argument for most of the pipenv commands and code paths.

Example usages:

Single Category

pipenv install six --catetgories prereq

Multiple categories

pipenv install --categories="prereq packages"

Lock and Uninstall

pipenv lock --categories="prereq dev-packages"
pipenv uninstall six --categories prereq

@matteius
Copy link
Member Author

I believe what is remaining is to:

  • write documentation
  • Create requirementslib and plette branches/PRs for those changes
  • Vendor in new requirementslib and plette once they are released.

@matteius matteius requested a review from oz123 September 26, 2022 02:49
pipenv/cli/command.py Outdated Show resolved Hide resolved
):
"""
Executes the installation functionality.

"""
procs = queue.Queue(maxsize=1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the queue size is always 1 do we even need a queue?

pipenv/core.py Outdated Show resolved Hide resolved
@oz123
Copy link
Contributor

oz123 commented Oct 1, 2022

@matteius tremendous job! As you stated, the docs are still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category-based package installation
2 participants