Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pipenv check with minimal output #5480

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

yeisonvargasf
Copy link
Contributor

The issue

  • The pipenv new Safety implementation is using a subprocess.

  • There isn't a non-verbose output.

This pull request is related to #5218

The fix

  • pipenv check uses Safety directly, replacing the Safety implementation with a subprocess.

  • Added a new minimal output, a non-verbose output.

@yeisonvargasf
Copy link
Contributor Author

@matteius and @oz123, please review it and let me know if you need any further changes so this PR can be merged into the @matteius branch (vendor-latest-safety2).

Note: CI will probably fail as the main branch CI status is also falling.

pipenv/core.py Outdated Show resolved Hide resolved
pipenv/core.py Show resolved Hide resolved
pipenv/core.py Outdated Show resolved Hide resolved
@matteius matteius merged commit 43c87b8 into pypa:vendor-latest-safety2 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants