Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python3.7 #5879

Merged
merged 7 commits into from Oct 20, 2023
Merged

Conversation

deronnax
Copy link
Contributor

The issue

Drop support for Python 3.7

The fix

It's obvious

The checklist

  • Associated issue : Drop support for Python 3.7 #5819
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #. : incoming

@deronnax deronnax marked this pull request as draft August 28, 2023 09:24
@matteius
Copy link
Member

I will be holding off on this one until we are satisfied that the recent releases are working for the majority of use cases.

@matteius
Copy link
Member

Also, this change will conflict with: #5836

@deronnax
Copy link
Contributor Author

No worries, I will wait. And no worries for the conflicting change, I will update my PR, the conflict won't be a big thing.

@deronnax
Copy link
Contributor Author

deronnax commented Sep 6, 2023

I will resume work now that #5836 is merged.

@matteius matteius mentioned this pull request Sep 7, 2023
2 tasks
@matteius
Copy link
Member

It is time to take this up again.

@deronnax deronnax marked this pull request as ready for review October 11, 2023 11:34
@deronnax
Copy link
Contributor Author

I think we're good.

@matteius
Copy link
Member

pyptoject.toml needs to remove the python 3.7 support line or else the pip resolver will still try to install this for 3.7 versions.

@matteius
Copy link
Member

Also please add a news fragment stating we are dropping support for 3.7

@matteius matteius changed the title drop python3.7 Drop support for python3.7 Oct 20, 2023
@deronnax
Copy link
Contributor Author

Sorry, some changes had not been pushed. I attempted to go a step more in the cleaning, the even more cleaning commit, but I got errors I did not understand so I reverted it. If you can tell me what was wrong, it could be done in a different PR.

@matteius matteius merged commit 04f0106 into pypa:main Oct 20, 2023
16 checks passed
@deronnax
Copy link
Contributor Author

Arg. It should have been squash-merged. But thank you.

@matteius
Copy link
Member

matteius commented Oct 20, 2023

@deronnax I've gotten feedback both ways -- usually people want the regular merge because if I squash merge it gives me credit for your commit or something -- anyway, thanks for your contribution! Worst case is the revert button from the PR will undo the whole changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants