Solving slashes or other less usual symbols in vcs refs were not being interpreted correctly. #5935
Conversation
There was a problem hiding this comment.
In general, looks ok. Just the tests look scary.
Would like to hear if @thehesiod approve that these changes work.
Can this branch upstream be protected from removal?
| ): | ||
| pypi_lockfile["default"]["google-api-python-client"] = { | ||
| "git": "https://github.com/thehesiod/google-api-python-client.git@thehesiod/batch-retries2", | ||
| "markers": "python_version >= '3.7'", |
There was a problem hiding this comment.
Will this test break if the branch is removed?
We should have an isolated test that does not depend on other people's repository.
There was a problem hiding this comment.
These are unit level tests but I had to do them as integration to leverage the pipfile/lockfile stuff we get from those fixtures, but I am starting to write tests that are more unit level in nature -- so we are really just testing the string conversions that happen through these constructs -- no actual lock resolution or installation happening in these tests. More like is it giving intelligible things to pip resolver or installer based on the inputs. For example, that commit hash was from a different test and not actually part of that repo.
There was a problem hiding this comment.
you can use your own repo with a fake branch too right?
There was a problem hiding this comment.
I don't care using mine, however I'm guessing you'll want to keep your own long term ;)
There was a problem hiding this comment.
These are unit level tests but I had to do them as integration to leverage the pipfile/lockfile stuff we get from those fixtures, but I am starting to write tests that are more unit level in nature -- so we are really just testing the string conversions that happen through these constructs -- no actual lock resolution or installation happening in these tests. More like is it giving intelligible things to pip resolver or installer based on the inputs. For example, that commit hash was from a different test and not actually part of that repo.
You also submit a PR with the example files to plette repo. I started a collection of test cases there.
Thank you for contributing to Pipenv!
The issue
Fixes issue #5934
The fix
urllib urlparse has to be better at separating netlocs from the remaining path than I can do.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.