Fix combining of --editable and --force flag
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-editable-force-install
branch
2 times, most recently
from
4570bd7
to
83b9450
Compare
The 1.3.0 version of `pipx` (with pypa#933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: pypa#1122
potiuk
force-pushed
the
fix-editable-force-install
branch
from
83b9450
to
9cab360
Compare
gaborbernat
requested changes
Dec 2, 2023
gaborbernat
approved these changes
Dec 2, 2023
|
Oh. Fantastic ❤️ . Thanks for so speedy acceptance! Q: are you going to release 1.3.1 ~ quickly and yank 1.3.0 maybe ? No strong need for yanking (this is rather an edge case) so it's more to see what's your thinking is there :) In our CI I already added |
|
No yanking but https://github.com/pypa/pipx/actions/runs/7072334702 |
|
👍 🎉 🎉 🎉 🎉 🎉 👍 |
|
And released ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
The 1.3.0 version of
pipx(with #933) introduced a but where the--force-reinstallflag caused failure when also the--editableflag was used - because it was adding the--force-reinstallflag after--editableone (and--editableflag expects url/path to the Python package to install to follow it.The change fixes it by adding the
--force-reinstallflag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem.Fixes: #1122
Test plan
Tested by running