Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logo more visible in dark mode #1135

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

dukecat0
Copy link
Member

@dukecat0 dukecat0 commented Dec 4, 2023

  • I have added an entry to docs/changelog.md

Summary of changes

Make the logo more visible in dark mode.
Closes #1059

Test plan

Tested by running

# command(s) to exercise these changes

CHANGELOG.md Outdated Show resolved Hide resolved
@gaborbernat gaborbernat merged commit d768ba9 into pypa:main Dec 4, 2023
14 checks passed
@dukecat0 dukecat0 deleted the visible branch December 4, 2023 15:29
@webknjaz
Copy link
Member

webknjaz commented Dec 6, 2023

FTR I checked the text color (#898988) against the dark dimmed theme background (#22272E) via https://webaim.org/resources/contrastchecker/ and it says that the contrast is not very good for text, especially small, but is fine for big UI elements, which I suppose the logo counts as.

Either way, I like the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[appearance][accessibility][Dark Mode] Poor logo visibility in the README: low contrast
3 participants