Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump changelog for 1.4.2 #1202

Merged
merged 2 commits into from Jan 12, 2024
Merged

Bump changelog for 1.4.2 #1202

merged 2 commits into from Jan 12, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jan 12, 2024

  • I have added an entry to docs/changelog.md

Summary of changes

This still doesn't work as expected. @henryiii I tried your suggestion, but get the same error.

Test plan

Tested by running

# command(s) to exercise these changes

@henryiii
Copy link
Contributor

@chrysle
Copy link
Contributor Author

chrysle commented Jan 12, 2024

Now it works! The permissions were in the wrong section. See chrysle#1

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 0c4fd1b into main Jan 12, 2024
26 checks passed
@gaborbernat gaborbernat deleted the bump-changelog-for-1.4.2 branch January 12, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants