Apply assorted ruff rules #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RET504 Unnecessary assignment to `...` before `return` statement
SIM910 Use `json_dict.get(...)` instead of `json_dict.get(..., None)`
UP021 `universal_newlines` is deprecated, use `text`
UP031 Use format specifiers instead of percent format
TRY300 Consider moving this statement to an `else` block
PERF401 Use a list comprehension to create a transformed list
EXE001 Shebang is present but file is not executable
DimitriPapadopoulos
force-pushed
the
assorted
branch
from
7bfb2e4
to
11bb0e2
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Response to #1408 (comment).
I tried
ruff check --select=ALLand applied rules that are not pedantic and avoid extensive changes.Test plan
Tested by running