Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0: Bump changelog #1432

Merged
merged 2 commits into from
May 29, 2024
Merged

1.6.0: Bump changelog #1432

merged 2 commits into from
May 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the release-version Given to PRs that should trigger CD label May 28, 2024
Gitznik
Gitznik previously approved these changes May 28, 2024
@chrysle chrysle closed this May 29, 2024
@chrysle chrysle reopened this May 29, 2024
Copy link
Member

@dukecat0 dukecat0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the first letters to capital should make them look more consistent.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
github-actions bot and others added 2 commits May 29, 2024 20:03
Co-authored-by: Jason Lam <meowmeowcat1211@gmail.com>
@huxuan huxuan merged commit 697de21 into main May 29, 2024
11 checks passed
@huxuan huxuan deleted the bump-changelog-for-1.6.0 branch May 29, 2024 13:23
@huxuan
Copy link
Contributor

huxuan commented May 29, 2024

Seems there is an invalid publisher errror, some configuration is needed on pypi side?

https://github.com/pypa/pipx/actions/runs/9286951300

@chrysle
Copy link
Contributor

chrysle commented May 29, 2024

I realize I'm an idiot now, too.. There is no Git tag created before uploading. It builds the SDist and wheel for version 0.1.

I suggest fixing this in another pull request and releasing by that.

@chrysle
Copy link
Contributor

chrysle commented May 29, 2024

Seems there is an invalid publisher errror, some configuration is needed on pypi side?

Yes, the workflow name is wrong (https://docs.pypi.org/trusted-publishers/adding-a-publisher/).

@chrysle
Copy link
Contributor

chrysle commented May 30, 2024

@gaborbernat Since you're a maintainer on PyPI, could you do the necessary amendment? Probably we should also widen the range of PyPI maintainers, I've seen @huxuan, @Gitznik and @dukecat0 (https://pypi.org/user/meowmeowcat/) have accounts.

@dukecat0
Copy link
Member

(pypi.org/user/meowmeowcat)

Btw, I have set up a new account for this and it's https://pypi.org/user/dukecat0/.

@gaborbernat
Copy link
Contributor

(pypi.org/user/meowmeowcat)

Btw, I have set up a new account for this and it's pypi.org/user/dukecat0.

Invited you.

@gaborbernat
Copy link
Contributor

Note https://github.com/pypa/pipx/actions/runs/9286951300/job/25688133136 shows the release generation is broken even after the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version Given to PRs that should trigger CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants