Fix suffixed venv uninstall, and fix suffixed venv install summary. #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.md
Summary of changes
Closes #652 .
On non-symlinked filesystems like typical Windows filesystems, pipx didn't actually delete apps in the local binary dir associated with a suffixed venv. This fixes that.
Also, when summarizing an install, on a non-symlink filesystem (Windows) we would normally not properly handle the installed binaries, reporting each app with
(symlink missing or pointing to unexpected location)
Also updated tests to test the functionality that we now do correctly.
Test plan
On Windows!
Install
This PR:
pipx 0.16.1.0
Uninstall
This PR:
pipx 0.16.1.0