Add list --short option #804
Conversation
There was a problem hiding this comment.
Cool, looks pretty good!
Could you add example output to the summary?
Should --short flag have precedence over --json flag?
These should be mutually exclusive. You should be able to do this with https://docs.python.org/3/library/argparse.html#mutual-exclusion.
Should --include-injected flag be accepted with --short?
Probably not, since it wouldn't be very short in that case. Thoughts @njthomas?
Done. |
| def test_list_short(pipx_temp_env, monkeypatch, capsys): | ||
| assert not run_pipx_cli(["install", PKG["pycowsay"]["spec"]]) | ||
| assert not run_pipx_cli(["install", PKG["pylint"]["spec"]]) | ||
| captured = capsys.readouterr() | ||
|
|
||
| assert not run_pipx_cli(["list", "--short"]) | ||
| captured = capsys.readouterr() | ||
|
|
||
| assert "pycowsay 0.0.0.1" in captured.out | ||
| assert "pylint 2.3.1" in captured.out |
|
@cs01 but why did tests fail on macos? |
Where are you seeing that? (edit: nevermind, I see it now; it was hidden on my phone) Tests were failing on main until just a couple days ago so that may have been the reason. Either way everything is merged and passing now. |
docs/changelog.mdSummary of changes
#792
Should
--shortflag have precedence over--jsonflag?Should
--include-injectedflag be accepted with--short?Test plan
Tested by running