Add PEP 660 support #119
Merged
Add PEP 660 support #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sbidoul
commented
Jul 9, 2021
•
sbidoul
commented
- tests
- changelog
Factor out the wheel building operation so the metadata extraction logic can be resused for editables.
So we get a precise exception when prepare_metadata_for_build_editable fallback fails due to a missing build_editable hook.
|
This should be ready for review/comments. It is mostly a straightforward copy of the wheel hooks, with a small difference in the Do not merge just yet as I'll do more integration testing with pip. |
|
I did further testing with pip. This should be good for merging. |
|
Thanks @sbidoul ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.