Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip markdown tests if cmarkgfm is not installed. #278

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

tillahoffmann
Copy link
Contributor

Does what it says on the tin. Is this what you had in mind to close #275, @miketheman?

Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

run: python -m tox -e py
run: |
python -m tox -e py
python -m tox -e noextra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding!

path = pathlib.Path("tests/fixtures", request.param)
# Skip markdown tests if the cmarkgfm optional dependency is not installed.
if path.suffix == ".md":
pytest.importorskip("cmarkgfm")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool API, I hadn't seen this before, and it's kind of perfect.

@miketheman miketheman merged commit 8f1fb59 into pypa:main Apr 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

37.3: pytest fails in in 6 units
2 participants