Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid address errors #65

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Handle invalid address errors #65

merged 2 commits into from
Mar 8, 2018

Conversation

di
Copy link
Sponsor Member

@di di commented Mar 6, 2018

bleach==2.1.3 now raises a ValueError: Invalid IPv6 URL exception from urllib if it tries to parse an invalid URL.

There's also other places where it may raise a ValueError while sanitizing, so catch them all and just fail the render instead of bubbling up the exception.

@di di requested a review from dstufft March 6, 2018 06:49
@dstufft dstufft merged commit feb9a0e into pypa:master Mar 8, 2018
@di di deleted the handle-invalid-address-errors branch March 8, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstufft dstufft Awaiting requested review from dstufft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@di @dstufft