Skip to content

Commit

Permalink
Update all setup.py's to zip_safe=False.
Browse files Browse the repository at this point in the history 
This prevents zipped eggs from being installed, and seems to
improve overall compatiblity, as discussed in #6.
Installations now pass in 95/160 combos, instead of only 72/160.
  • Loading branch information
@swolebro
swolebro committed Nov 1, 2017
1 parent afd4109 commit fcd89c2
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 26 deletions.
3 changes: 2 additions & 1 deletion native/pkg_a/setup.py
View file
Expand Up @@ -28,5 +28,6 @@

license='Apache Software License',

packages=['example_pkg.a']
packages=['example_pkg.a'],
zip_safe=False,
)
1 change: 1 addition & 0 deletions native/pkg_b/setup.py
View file
Expand Up @@ -29,4 +29,5 @@
license='Apache Software License',

packages=['example_pkg.b'],
zip_safe=False,
)
3 changes: 2 additions & 1 deletion pkg_resources/pkg_a/setup.py
View file
Expand Up @@ -29,5 +29,6 @@
license='Apache Software License',

This comment has been minimized.

Sign in to view

Copy link
@Murathlc

Murathlc Nov 28, 2022

pkg_resources/pkg_a/setup.py
packages=find_packages(),

This comment has been minimized.

Sign in to view

Copy link
@Murathlc

Murathlc Nov 28, 2022

pkg_resources/pkg_a/setup.py
namespace_packages=['example_pkg']

This comment has been minimized.

Sign in to view

Copy link
@Murathlc

Murathlc Nov 28, 2022

native/pkg_b/setup.py
namespace_packages=['example_pkg'],
zip_safe=False,

This comment has been minimized.

Sign in to view

Copy link
@Murathlc

Murathlc Nov 28, 2022

native/pkg_b/setup.py``
)
3 changes: 2 additions & 1 deletion pkg_resources/pkg_b/setup.py
View file
Expand Up @@ -29,5 +29,6 @@
license='Apache Software License',

packages=find_packages(),
namespace_packages=['example_pkg']
namespace_packages=['example_pkg'],
zip_safe=False,
)
1 change: 1 addition & 0 deletions pkgutil/pkg_a/setup.py
View file
Expand Up @@ -29,4 +29,5 @@
license='Apache Software License',

packages=find_packages(),
zip_safe=False,
)
1 change: 1 addition & 0 deletions pkgutil/pkg_b/setup.py
View file
Expand Up @@ -29,4 +29,5 @@
license='Apache Software License',

packages=find_packages(),
zip_safe=False,
)
46 changes: 23 additions & 23 deletions table.md
View file
Expand Up @@ -24,10 +24,10 @@
| cross_pep420_pkgutil | python3 | pip install -e . | pip install -e . | ✅ |
| cross_pep420_pkgutil | python3 | pip install -e . | python setup.py install | ✅ |
| cross_pep420_pkgutil | python3 | pip install -e . | python setup.py develop | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py install | pip install . | ❌ |
| cross_pep420_pkgutil | python3 | python setup.py install | pip install -e . | ❌ |
| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py install | ❌ |
| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py develop | ❌ |
| cross_pep420_pkgutil | python3 | python setup.py install | pip install . | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py install | pip install -e . | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py install | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py develop | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py develop | pip install . | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py develop | pip install -e . | ✅ |
| cross_pep420_pkgutil | python3 | python setup.py develop | python setup.py install | ✅ |
Expand All @@ -40,7 +40,7 @@
| cross_pkg_resources_pkgutil | python2 | pip install -e . | pip install -e . | ❌ |
| cross_pkg_resources_pkgutil | python2 | pip install -e . | python setup.py install | ❌ |
| cross_pkg_resources_pkgutil | python2 | pip install -e . | python setup.py develop | ❌ |
| cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install . | ❌ |
| cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install . | ✅ |
| cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install -e . | ✅ |
| cross_pkg_resources_pkgutil | python2 | python setup.py install | python setup.py install | ✅ |
| cross_pkg_resources_pkgutil | python2 | python setup.py install | python setup.py develop | ✅ |
Expand All @@ -56,7 +56,7 @@
| cross_pkg_resources_pkgutil | python3 | pip install -e . | pip install -e . | ❌ |
| cross_pkg_resources_pkgutil | python3 | pip install -e . | python setup.py install | ❌ |
| cross_pkg_resources_pkgutil | python3 | pip install -e . | python setup.py develop | ❌ |
| cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install . | ❌ |
| cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install . | ✅ |
| cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install -e . | ✅ |
| cross_pkg_resources_pkgutil | python3 | python setup.py install | python setup.py install | ✅ |
| cross_pkg_resources_pkgutil | python3 | python setup.py install | python setup.py develop | ✅ |
Expand All @@ -82,19 +82,19 @@
| pep420 | python2 | python setup.py develop | python setup.py develop | ❌ |
| pep420 | python3 | pip install . | pip install . | ✅ |
| pep420 | python3 | pip install . | pip install -e . | ✅ |
| pep420 | python3 | pip install . | python setup.py install | ❌ |
| pep420 | python3 | pip install . | python setup.py install | ✅ |
| pep420 | python3 | pip install . | python setup.py develop | ✅ |
| pep420 | python3 | pip install -e . | pip install . | ✅ |
| pep420 | python3 | pip install -e . | pip install -e . | ✅ |
| pep420 | python3 | pip install -e . | python setup.py install | ❌ |
| pep420 | python3 | pip install -e . | python setup.py install | ✅ |
| pep420 | python3 | pip install -e . | python setup.py develop | ✅ |
| pep420 | python3 | python setup.py install | pip install . | ❌ |
| pep420 | python3 | python setup.py install | pip install -e . | ❌ |
| pep420 | python3 | python setup.py install | python setup.py install | ❌ |
| pep420 | python3 | python setup.py install | python setup.py develop | ❌ |
| pep420 | python3 | python setup.py install | pip install . | ✅ |
| pep420 | python3 | python setup.py install | pip install -e . | ✅ |
| pep420 | python3 | python setup.py install | python setup.py install | ✅ |
| pep420 | python3 | python setup.py install | python setup.py develop | ✅ |
| pep420 | python3 | python setup.py develop | pip install . | ✅ |
| pep420 | python3 | python setup.py develop | pip install -e . | ✅ |
| pep420 | python3 | python setup.py develop | python setup.py install | ❌ |
| pep420 | python3 | python setup.py develop | python setup.py install | ✅ |
| pep420 | python3 | python setup.py develop | python setup.py develop | ✅ |
| pkg_resources | python2 | pip install . | pip install . | ✅ |
| pkg_resources | python2 | pip install . | pip install -e . | ✅ |
Expand Down Expand Up @@ -130,33 +130,33 @@
| pkg_resources | python3 | python setup.py develop | python setup.py develop | ✅ |
| pkgutil | python2 | pip install . | pip install . | ✅ |
| pkgutil | python2 | pip install . | pip install -e . | ✅ |
| pkgutil | python2 | pip install . | python setup.py install | ❌ |
| pkgutil | python2 | pip install . | python setup.py install | ✅ |
| pkgutil | python2 | pip install . | python setup.py develop | ✅ |
| pkgutil | python2 | pip install -e . | pip install . | ✅ |
| pkgutil | python2 | pip install -e . | pip install -e . | ✅ |
| pkgutil | python2 | pip install -e . | python setup.py install | ❌ |
| pkgutil | python2 | pip install -e . | python setup.py install | ✅ |
| pkgutil | python2 | pip install -e . | python setup.py develop | ✅ |
| pkgutil | python2 | python setup.py install | pip install . | ❌ |
| pkgutil | python2 | python setup.py install | pip install . | ✅ |
| pkgutil | python2 | python setup.py install | pip install -e . | ✅ |
| pkgutil | python2 | python setup.py install | python setup.py install | ❌ |
| pkgutil | python2 | python setup.py install | python setup.py install | ✅ |
| pkgutil | python2 | python setup.py install | python setup.py develop | ✅ |
| pkgutil | python2 | python setup.py develop | pip install . | ✅ |
| pkgutil | python2 | python setup.py develop | pip install -e . | ✅ |
| pkgutil | python2 | python setup.py develop | python setup.py install | ❌ |
| pkgutil | python2 | python setup.py develop | python setup.py install | ✅ |
| pkgutil | python2 | python setup.py develop | python setup.py develop | ✅ |
| pkgutil | python3 | pip install . | pip install . | ✅ |
| pkgutil | python3 | pip install . | pip install -e . | ✅ |
| pkgutil | python3 | pip install . | python setup.py install | ❌ |
| pkgutil | python3 | pip install . | python setup.py install | ✅ |
| pkgutil | python3 | pip install . | python setup.py develop | ✅ |
| pkgutil | python3 | pip install -e . | pip install . | ✅ |
| pkgutil | python3 | pip install -e . | pip install -e . | ✅ |
| pkgutil | python3 | pip install -e . | python setup.py install | ❌ |
| pkgutil | python3 | pip install -e . | python setup.py install | ✅ |
| pkgutil | python3 | pip install -e . | python setup.py develop | ✅ |
| pkgutil | python3 | python setup.py install | pip install . | ❌ |
| pkgutil | python3 | python setup.py install | pip install . | ✅ |
| pkgutil | python3 | python setup.py install | pip install -e . | ✅ |
| pkgutil | python3 | python setup.py install | python setup.py install | ❌ |
| pkgutil | python3 | python setup.py install | python setup.py install | ✅ |
| pkgutil | python3 | python setup.py install | python setup.py develop | ✅ |
| pkgutil | python3 | python setup.py develop | pip install . | ✅ |
| pkgutil | python3 | python setup.py develop | pip install -e . | ✅ |
| pkgutil | python3 | python setup.py develop | python setup.py install | ❌ |
| pkgutil | python3 | python setup.py develop | python setup.py install | ✅ |
| pkgutil | python3 | python setup.py develop | python setup.py develop | ✅ |

0 comments on commit fcd89c2

Please sign in to comment.