Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix usage of extras when installing via Wheels; resolves #882
When resolving requirements, we now pass the list of extras we're using along to Marker.evaluate, since we want to include the extra's requirements in our list of required packages. This is sort of papering over the underlying issue; namely, that the dependency map for dist-info distributions looks like: { None : ['common_dep'], 'my_extra': ['extra_dep; extra = "my_extra"'] } If we eliminated 'extra = "my_extra"' when creating this map, the problem would go away because the WorkingSet would no longer treat `extra_dep` as a purely optional dependency. However, this would require copying and manipulating Requirement objects, which is somewhat more complicated than the current solution.
- Loading branch information
Jim Porter
committed
Dec 29, 2016
1 parent
a5b81d8
commit 8c1f489
Showing
1 changed file
with
17 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters