Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error decoding config in extract_wininst_cfg #114

Closed
ghost opened this issue Nov 23, 2013 · 1 comment
Closed

Error decoding config in extract_wininst_cfg #114

ghost opened this issue Nov 23, 2013 · 1 comment
Labels
bug major

Comments

@ghost
Copy link

ghost commented Nov 23, 2013

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)

In pull request 20, Sascha suggests there are cases where easy_install will fail to install a bdist_wininst if the config for that build has non-ascii characters. Investigating the bdist_wininst command, I found that the command uses 'mbcs' for file encoding.

I believe easy_install should use getfilesystemencoding for good compatibility on Windows a best-effort fallback on other operating systems.
@ghost
Copy link
Author

ghost commented Nov 23, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

Use sys.getfilesystemencoding for decoding bdist_wininst config. Fixes #114.

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this as completed Mar 29, 2016
jaraco added a commit that referenced this issue Jan 30, 2022
@jaraco
Merge pull request #114 from imba-tjd/patch-1
4471eee 
Use super()
jaraco added a commit that referenced this issue Feb 4, 2023
@jaraco
Use sys.getfilesystemencoding for decoding bdist_wininst config. Fixes …
63f856f 
…#114.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants