/setuptools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfriendly error message when unicode is passed to package_dir or packages #190

Closed
bb-migration opened this Issue Apr 15, 2014 · 0 comments

Comments

Assignees
No one assigned
Labels
enhancement major
Projects
None yet
Milestone
No milestone
1 participant
@bb-migration
@bb-migration

bb-migration commented Apr 15, 2014 •
edited by jaraco

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)

Adding __future__.unicode_literals causes setup.py scripts to fail. In the mailman project, here is an example error when running python2 setup.py build:

running build
running build_py
Traceback (most recent call last):
  File "setup.py", line 112, in <module>
    test_suite = 'nose2.collector.collector',
  File "C:\Program Files\Python27\lib\distutils\core.py", line 152, in setup
    dist.run_commands()
  File "C:\Program Files\Python27\lib\distutils\dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "C:\Program Files\Python27\lib\distutils\dist.py", line 972, in run_command
    cmd_obj.run()
  File "C:\Program Files\Python27\lib\distutils\command\build.py", line 127, in run
    self.run_command(cmd_name)
  File "C:\Program Files\Python27\lib\distutils\cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "C:\Program Files\Python27\lib\distutils\dist.py", line 972, in run_command
    cmd_obj.run()
  File "build\bdist.win-amd64\egg\setuptools\command\build_py.py", line 42, in run
  File "C:\Program Files\Python27\lib\distutils\command\build_py.py", line 372, in build_packages
    self.build_module(module, module_file, package)
  File "build\bdist.win-amd64\egg\setuptools\command\build_py.py", line 60, in build_module
  File "C:\Program Files\Python27\lib\distutils\command\build_py.py", line 333, in build_module
    "'package' must be a string (dot-separated), list, or tuple")
TypeError: 'package' must be a string (dot-separated), list, or tuple

A different error occurs when using 'develop':

running develop
error: 'egg_base' must be a directory name (got `src`)

Setuptools could make this error message nicer.

@bb-migration bb-migration added major enhancement labels Mar 29, 2016

benjaoming added a commit to benjaoming/setuptools that referenced this issue May 27, 2016

@benjaoming
Ensure package name isn't unicode in Python2 distutils 
Problem encountered on Ubuntu 14.04

Fixes pypa#190

If people need to fix this without this patch, they have to wrap their package names in `str()` like so:

```python
#!/usr/bin/env python
# -*- coding: utf-8 -*-
from __future__ import absolute_import, print_function, unicode_literals

setup(
    # ....
    package_dir=[
        str('package_name'),
    ]
)
```
fc676e1

@benjaoming benjaoming referenced this issue May 27, 2016

Merged

Ensure package name isn't unicode in Python2 distutils #597

benjaoming added a commit to benjaoming/setuptools that referenced this issue Jun 2, 2016

@benjaoming
Fixing pypa#190 following proposal by @jaraco
abb862c

benjaoming added a commit to benjaoming/setuptools that referenced this issue Jun 2, 2016

@benjaoming
Fixing pypa#190 following proposal by @jaraco
11d5bb9

@jaraco jaraco closed this in #597 Jun 3, 2016

@webknjaz webknjaz referenced this issue Aug 27, 2017

Open

[BUG] Invalid string type when reading declarative `setup.cfg` under Python 2 #1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment