New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCompiler self.include_dirs
modified during each compile()
#3591
Comments
This was referenced Sep 14, 2022
This also broke our NumPy builds with Python 3.11 under Windows. The above-mentioned change fixes this. Would it help to make a PR with the fix? |
mrbean-bremen
added a commit
to mrbean-bremen/setuptools
that referenced
this issue
Jan 18, 2023
2 tasks
mrbean-bremen
added a commit
to mrbean-bremen/distutils
that referenced
this issue
Jan 18, 2023
mrbean-bremen
added a commit
to mrbean-bremen/distutils
that referenced
this issue
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cf. 9f9a3e5
setuptools/setuptools/_distutils/ccompiler.py
Lines 390 to 398 in ba3995e
setuptools/setuptools/_distutils/_msvccompiler.py
Lines 228 to 233 in ba3995e
With msvc, the class
include_dirs
is not empty, and will be appended to the instanceinclude_dirs
for eachcompile(..., include_dirs=None)
(which is the default). With enough calls, an impressively long argument list accumulates, resulting in an error:I think that one simple fix would be:
The text was updated successfully, but these errors were encountered: