Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-imported reference to urlsplit and urlunsplit causes breakage of dependency_links #53

Closed
ghost opened this issue Jul 24, 2013 · 3 comments
Labels

Comments

@ghost
Copy link

@ghost ghost commented Jul 24, 2013

Originally reported by: Anonymous


In commit 6015632, the package_index.py file's imports were changed. A direct import of urllib was replaced with a "from setuptools.compat import ( ..." statement. This was all fine and good for most of the file, but a few things got missed.

Specifically, the _vcs_split_rev_from_url method of PackageIndex contains a reference to urlsplit and urlunsplit. These references were formerly qualified with "urllib." prior to the commit, but after the commit were left unqualified ... and without imports from setuptools.compat.

The end-user affect of this is that if you include a URL in the dependency_links section of your setup call (a git URL with a revision and egg name, in my instance), setuptools is likely to puke on it.

Should be a simple fix: Just import those functions. But given the nature of this bug, someone might want to go back over that entire commit carefully to make sure no other similar bugs were introduced. (And if someone added a test case for the dependency_links feature with a complex VCS url, I certainly wouldn't complain. ;-) )


@ghost
Copy link
Author

@ghost ghost commented Jul 24, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Import urlsplit and urlunsplit from compat module. Fixes #53.

@ghost
Copy link
Author

@ghost ghost commented Jul 24, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


As suggested, in addition to the simple fix, I've extended the tests (acc09758ac3f) and improved the ability of a linter to detect these errors (fe4fc0aa26b4).

@ghost
Copy link
Author

@ghost ghost commented Jul 24, 2013

Original comment by joellathrop (Bitbucket: joellathrop, GitHub: Unknown):


You, sir, are awesome. Thanks for the rapid turn-around. :-)

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this Mar 29, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants