-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests run twice with setup.py test in python3.5 #701
Comments
i currently use latest version of setuptools 25.1.0 |
I'm not sure why this happens.
Are you saying that the problem does not occur with setuptools 18.3.x and earlier? Would you be willing to investigate deeper and track down the cause? |
I do something like git bisect on it and found the exact version! It is first version that implement a new way to find tests, before it (18.3.3 and down) the test model must explicitly defined as argument (with -s key). |
That's excellent work! Now we can go to the changelog for 18.4 and see that the change originated with #446. So that at least explains why things changed with 18.4. |
I know, I read the source code and try to fix it locally and if can do anything I would submit a pull request to fix it. but I fail! I read the changelog after I have found that the problem is in 18.4! :) the @bb-migration mark #446 as major bug, so I dont alone with this problem! setuptools will install the same on ether py3.4 or py3.5. |
@wtayyeb any updates? |
@sigmavirus24 nope! |
You might also test again with v30.2.1 based on the changes introduced in #850. |
With |
Looks like with Python 3 (or at least 3.4, 3.5, 3.6, I don't have 3.3 to test), To fix the fact that tests are not run with Python 2, adding |
Hi.
The
setup.py test
in python3.5 result to twice test run.the very simple project to reproduce the problem is located at https://github.com/wtayyeb/setuptools-twice-test which have three tests
by running it via
tox
you could see that for py27 no test found (legacy behaviour, needdiscover
to find them) and for py34 the behaviour is fixed and three tests were run. but in py35 it run 6 tests, as they are doublicated.if we use
setup.py test -s dummy
all three environment will report 3 test run. but it is not the general way. also when runpython -m unittest discover
it also result correctly 3 test for each python version.In case of using legacy woraround that create test_command that add
discover
to unittest args, the problem still exists for py35.the result of tox is like below
The text was updated successfully, but these errors were encountered: