Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnicodeDecodeError in easy_install with unicode characters in sdist when LANG=C #706

Closed
jaraco opened this issue Jul 30, 2016 · 1 comment
Closed

UnicodeDecodeError in easy_install with unicode characters in sdist when LANG=C #706

jaraco opened this issue Jul 30, 2016 · 1 comment

Comments

@jaraco
Copy link
Member

jaraco commented Jul 30, 2016

In investigating #704, I added a test which creates an sdist with unicode charecters in one of the filenames. Turns out this test is also failing on Linux when LANG=C.
jaraco added a commit that referenced this issue Jul 30, 2016
@jaraco
Mark test as xfail. Ref #706.
2e8a63b
@jaraco
Copy link
Member Author

jaraco commented Dec 21, 2016

As reported in the upstream bug, following the fix for #704, some packages (notably Sphinx, but any package that contains non-ascii filenames) will fail to cleanup after install with a UnicodeDecodeError in rmtree.

It sounds like the recommended fix is to provide a platform-specific workaround to pass bytes to rmtree when on Python 2 and Linux.

@jaraco jaraco closed this as completed in f0b7aeb Dec 21, 2016
@jaraco jaraco changed the title Test failures with unicode characters in sdist when LANG=C UnicodeDecodeError in easy_install with unicode characters in sdist when LANG=C Dec 21, 2016
jaraco added a commit that referenced this issue Dec 21, 2016
@jaraco
Cast the value to rmtree to bytes on Linux and Python 2 when the file…
5ad1371 
…systemencoding is ascii, and let posixpath work its voodoo. Fixes #706.
jaraco added a commit that referenced this issue Dec 21, 2016
@jaraco
Update changelog. Ref #706.
adf6cc7
@jaraco jaraco mentioned this issue Feb 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco