Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nspkg.pth magic when PEP-420 is available #805

Closed
jaraco opened this issue Oct 1, 2016 · 2 comments
Closed

Disable nspkg.pth magic when PEP-420 is available #805

jaraco opened this issue Oct 1, 2016 · 2 comments

Comments

@jaraco
Copy link
Member

@jaraco jaraco commented Oct 1, 2016

In pypa/pip#1924, we find that setuptools is generating the -nspkg.pth files that are bootstrapping the namespace packages, but these files are unnecessary when PEP-420 is present (Python 3.3+) and in fact interfere with pure PEP-420 namespace packages.

It seems the solution may be simple - bypass this behavior when PEP-420 is detected.

@jaraco
Copy link
Member Author

@jaraco jaraco commented Oct 1, 2016

Turns out the implementation is pretty straightforward. In the 'issue-805' branch, I've committed probably the minimal changes to support this functionality. I've tagged and released these changes as 28.1.0b1, a wheel that I've hosted here. I've confirmed the technique works. I'm going to run with this version of setuptools for a while and see if I encounter any issues.

I invite others to try it out as well. Just:

pip install https://github.com/pypa/setuptools/releases/download/v28.1.0b1/setuptools-28.1.0b1-py2.py3-none-any.whl
@jaraco
Copy link
Member Author

@jaraco jaraco commented Oct 2, 2016

Merging with v28.1.0, I've cut a new wheel of 28.2.0b1:

pip install https://github.com/pypa/setuptools/releases/download/v28.2.0b1/setuptools-28.2.0b1-py2.py3-none-any.whl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant