New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for maintainer in PKG-INFO #1294
Conversation
262df89
to
4a8e39f
Compare
setuptools/tests/test_dist.py
Outdated
|
||
|
||
|
||
def roundtrip_tofile(attr_dict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! This is an artifact.
Per PEP 345, metadata Version 1.2 should support the Author, Maintainer, Author-Email and Maintainer-Email fields.
4a8e39f
to
d8170d7
Compare
Looks like you dropped checking for project_urls when moving the sieve from write_pkg_file() to get_metadata_version(), where it was previously setting a minimum metadata version of 1.2 per the Project-URL entry for PEP 345. Was that intentional, or an oversight? I'm just trying to figure out whether I should push a PR to readd the check for project_urls or whether it wasn't really necessary in the first place. |
@fungi I believe the reason that I dropped checking for That said, this is a heuristic based on metadata generated mostly from So it was intentional but probably wrong. Feel free to make a PR or issue to add it back. |
Thanks, will do. For the record, I found this specifically because I noticed after a new setuptools release I was suddenly ending up with PKG-INFO files claiming to be metadata version 1.1 compliant even though they included Project-URL entries. |
…tainer as author on PyPI - mutually exclusive?)" More than a year after the original commit this has been fixed in setuptools[1] so we can go back to the way it was intended to be. This reverts commit 34ff560. [1] pypa/setuptools#1294
…tainer as author on PyPI - mutually exclusive?)" More than a year after the original commit this has been fixed in setuptools[1] so we can go back to the way it was intended to be. This reverts commit 34ff560. [1] pypa/setuptools#1294
Fixes #1288.
I have not really gone through this with a fine-toothed comb to see if it meets all of the specifications of PEP 345, but this is at least a step in the right direction.