Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all pypi.python.org URLs to pypi.org #1340

Merged
merged 1 commit into from Apr 26, 2018
Merged

Update all pypi.python.org URLs to pypi.org #1340

merged 1 commit into from Apr 26, 2018

Conversation

jdufresne
Copy link
Contributor

@@ -319,7 +319,7 @@ def finalize_options(self):
self.all_site_dirs.append(normalize_path(d))
if not self.editable:
self.check_site_dir()
self.index_url = self.index_url or "https://pypi.python.org/simple"
self.index_url = self.index_url or "https://pypi.org/simple"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewdurbin @brainwane CCed for sanity check - is this the right thing to do?

Also, does this mean that the old versions of setuptools out there now are going to start breaking at the end of the week?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does this mean that the old versions of setuptools out there now are going to start breaking at the end of the week?

I don't think so. The linked blog states:

The address pypi.python.org will continue to redirect to Warehouse.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might suggest changing the default to https://pypi.org/simple/ to save a redirect.

$ curl -I https://pypi.org/simple
HTTP/2 301 
location: https://pypi.org/simple/

But otherwise this is 👍.

The pypi.python.org service will continue to operate for the foreseeable future as it is currently:

$ curl -I https://pypi.python.org/simple
HTTP/2 301 
location: https://pypi.org/simple
$ curl -I https://pypi.python.org/simple/
HTTP/2 301 
location: https://pypi.org/simple/

@@ -297,7 +297,7 @@ class PackageIndex(Environment):
"""A distribution index that scans web pages for download URLs"""

def __init__(
self, index_url="https://pypi.python.org/simple", hosts=('*',),
self, index_url="https://pypi.org/simple", hosts=('*',),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, might suggest changing to https://pypi.org/simple/ to save a redirect.

@jdufresne
Copy link
Contributor Author

I have updated all instances of https://pypi.org/simple to https://pypi.org/simple/.

@pganssle pganssle merged commit 81f5f85 into pypa:master Apr 26, 2018
@jdufresne jdufresne deleted the pypi branch October 19, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants