Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude *.py from *.py[co|d] wheel distributions #1574

Closed
wants to merge 1 commit into from
Closed

Add option to exclude *.py from *.py[co|d] wheel distributions #1574

wants to merge 1 commit into from

Conversation

shenghe
Copy link

@shenghe shenghe commented Nov 4, 2018

python setup.py sdist[_wheel] excludes *.py files.

Summary of changes

Closes #511

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

…ons.

python setup.py sdist[_wheel] excludes *.py files.
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib. At the very least, this change needs a test - one that would fail before the change and pass after.

@jaraco jaraco changed the title Fixes #511 : be able to exclude *.py from *.py[co|d] wheel distributi… Add option to exclude *.py from *.py[co|d] wheel distributions Dec 31, 2019

def find_package_modules(self, package, package_dir):
modules = orig.build_py.find_package_modules(self, package, package_dir)
if not self.distribution.include_package_data:
Copy link
Member

@jaraco jaraco Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it that the include_package_data is relevant to whether modules are included in package (hint: it shouldn't be, as package data is for non-module files)?

@jaraco
Copy link
Member

jaraco commented Feb 6, 2020

This PR appears to be abandoned. Feel free to revive.

@jaraco jaraco closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot exclude file in bdist
2 participants