Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Feature support #1979

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Remove Feature support #1979

merged 3 commits into from
Mar 8, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jan 19, 2020

Closes #65

I did note in the ticket that there are at least a couple of zope projects still relying on this behavior. These projects will need to direct their users to pin to an older Setuptools (currently <46) to support building with this functionality.

@jaraco jaraco merged commit dfd59c2 into master Mar 8, 2020
@jaraco jaraco deleted the debt/remove-features branch March 8, 2020 19:51
vahi added a commit to vahi/gw150914-fig4b that referenced this pull request Apr 3, 2020
…version 46.0

pypa/setuptools#1979

if not pinned, then the script will fail on import error
 ************************************************************
      sys.version_info < (3,) and warnings.warn(pre + "*" * 60 + msg + "*" * 60)
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/usr1/vahi/pip-install-HUT4hP/MarkupSafe/setup.py", line 6, in <module>
        from setuptools import setup, Extension, Feature
    ImportError: cannot import name Feature
ltvolks added a commit to ltvolks/docs-gcp that referenced this pull request Jan 15, 2021
ImportError: cannot import name 'Feature' from 'setuptools'

Setuptools 46 introduced a breaking change and removed Feature support
pypa/setuptools#1979

Fixed in pallets/markupsafe#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove 'Features'
1 participant