Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash under Python 2 #2134

Merged
merged 7 commits into from May 26, 2020
Merged

Crash under Python 2 #2134

merged 7 commits into from May 26, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 24, 2020

This change fully drops support for Python 2 on the master branch, causing an explicit crash if it happens to be installed and executed on Python 2.

Adds new documentation (to which the bit.ly link will point), giving users the best guidance we have today (and in the future) and ultimately leading to the issue template.

There's a part of me that's tempted to release this not as a backward-incompatible release, as the backward-incompatible release was 45.0 and this change is only an enforcement of that incompatibility that's been guarded by a warning since the 45 release.

Fixes #2094.

@jaraco jaraco requested a review from pganssle May 24, 2020 20:16
@jaraco
Copy link
Member Author

jaraco commented May 24, 2020

@McSinyx I'd be interested in your feedback as well.

@jaraco jaraco changed the title Drop support for Python 2 Crash under Python 2 May 24, 2020
Copy link
Contributor

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaraco, personally I believe this would give users better guidance. I also spot that in the issue template

To ease the transition, Setuptools 45 was released to continue to have Python 2 compatibility, but emit a strenuous warning that it will stop working.

and wonder if you want to remove this given setuptools will crash on purpose and that we're on version 46+ now. If this PR is to be merged with the crashing part, I think it is fair to bump the version to 47 for backward compatible distinction.

docs/python 2 sunset.txt Outdated Show resolved Hide resolved
docs/python 2 sunset.txt Outdated Show resolved Hide resolved
@jaraco
Copy link
Member Author

jaraco commented May 25, 2020

@jaraco, personally I believe this would give users better guidance. I also spot that in the issue template

To ease the transition, Setuptools 45 was released to continue to have Python 2 compatibility, but emit a strenuous warning that it will stop working.

and wonder if you want to remove this given setuptools will crash on purpose and that we're on version 46+ now. If this PR is to be merged with the crashing part, I think it is fair to bump the version to 47 for backward compatible distinction.

Good feedback. I was leaning away from make it an incompatible release because the guidance is unchanged (use Setuptools<45), but after you shared this, I agree, a breaking release would be valuable. I'll do that. I'll also update that guidance in the template. Thanks!

@jaraco jaraco force-pushed the feature/python-2-sunset-docs branch from cac5d3f to e0b3acb Compare May 25, 2020 14:35
@jaraco
Copy link
Member Author

jaraco commented May 25, 2020

Thanks for the feedback. I'll plan to release this tomorrow unless there are other emergent concerns.

@jaraco jaraco merged commit aa98900 into master May 26, 2020
@jaraco jaraco deleted the feature/python-2-sunset-docs branch May 26, 2020 21:58
@jaraco
Copy link
Member Author

jaraco commented May 26, 2020

Okay. So today I learned that Bit.ly link targets can't be updated, at least not without a paid plan, and even then seemingly not without a custom domain. I was expecting that was one main advantage to using bit.ly (right after shorter urls). I guess that means that users on setuptools 45 and 46 will always be directed to the bug or bug template :/.

@pganssle
Copy link
Member

Sorry I never responded to this, I'm fine with fully dropping support. Doesn't look like there's much progress in any of the stuff where I was worried that adoption would be held back by anyway, and we can't wait forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing compatibility for Python 2
4 participants